• src/sbbs3/qwk.cpp

    From rswindell@VERT to CVS commit on Sat Nov 12 15:56:27 2016
    src/sbbs3 qwk.cpp 1.64 1.65
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv1439

    Modified Files:
    qwk.cpp
    Log Message:
    Fixed typo when parsing VOTING.DAT: we're looking for the sender net *address* not the sender net *type* (the net-type is passed-in). This did result in a crash when parsing a voting.dat that contained a networked vote. Oops.


    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Tue Nov 15 18:54:11 2016
    src/sbbs3 qwk.cpp 1.68 1.69
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv11212

    Modified Files:
    qwk.cpp
    Log Message:
    Address gcc error:
    invalid conversion from æconst char*Æ to æchar*Æ


    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Wed Nov 16 02:47:43 2016
    src/sbbs3 qwk.cpp 1.69 1.70
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv23392

    Modified Files:
    qwk.cpp
    Log Message:
    Import polls from VOTING.DAT files.


    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Fri Nov 18 07:37:25 2016
    src/sbbs3 qwk.cpp 1.72 1.73
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv25828

    Modified Files:
    qwk.cpp
    Log Message:
    Resolved unused variable warning.


    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Sun Nov 20 03:20:02 2016
    src/sbbs3 qwk.cpp 1.74 1.75
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv4532

    Modified Files:
    qwk.cpp
    Log Message:
    Fix bug importing polls from QWK/REP packets:
    "Subject" wasn't being parsed from VOTING.DAT and is a required header field for polls, causing error: qwk.cpp line 1149 writing "/sbbs/data/subs/dove-sys" access=-105, as reported by echickenster.


    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Wed Nov 23 01:22:50 2016
    src/sbbs3 qwk.cpp 1.77 1.78
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv17265

    Modified Files:
    qwk.cpp
    Log Message:
    2 VOTING.DAT related fixes:
    - the in-order QWK voting data importing wasn't working because the
    ini sections returned from iniGetSectionList do not contain the square
    brackets. So search for just the hex-offset (into MESSAGES.DAT) rather
    than the offset in square brackets.
    - Stop zeroing the vote message upon import (oops), causing SMBLIB -105
    errors upon adding the votes.



    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Tue Feb 21 02:19:26 2017
    src/sbbs3 qwk.cpp 1.78 1.79
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv15184

    Modified Files:
    qwk.cpp
    Log Message:
    Fix potential crash (stack corruption) in qwk_route() reported by Hemo:
    If what appears to be a QWKnet addressed was passed, but the QWK-ID portion was exactly 9 characters, a 1-byte stack corruption would occur as the 10-char local variable (node) could be written with 11 chars (9-char QWK-ID, colon, null). The reported issue happend when attempting to send netmail to "hemo@ujointbbs" which is neither a valid Internet email address or a valid QWKnet address.


    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Mon Aug 14 07:03:00 2017
    src/sbbs3 qwk.cpp 1.79 1.80
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv16763

    Modified Files:
    qwk.cpp
    Log Message:
    Added bounds-check in qwk_route().
    Fix multi-choice poll import (from QWKnet) bug: MaxVotes was used for polls in (not "votes) in VOTING.DAT file. Oops.


    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Mon Mar 26 22:08:03 2018
    src/sbbs3 qwk.cpp 1.81 1.82
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv20301

    Modified Files:
    qwk.cpp
    Log Message:
    Don't log an error when a QWK-posted vote message is a dupe (just silently discard).
    Also, trim trailing white-spaces.



    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Wed Jul 25 01:20:51 2018
    src/sbbs3 qwk.cpp 1.83 1.84
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv22001

    Modified Files:
    qwk.cpp
    Log Message:
    Log an error if any files in the data/qnet/*.out directory could not be removed.



    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Tue Jan 1 07:56:31 2019
    src/sbbs3 qwk.cpp 1.86 1.87
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv8529

    Modified Files:
    qwk.cpp
    Log Message:
    When failing to import vote-msgs or poll-closure-msgs from a QWKnet hub,
    change the errormsg() call to just a debug-level log message. These failures are expected if the local system (QWKnet node) didn't get the original poll message, for example.
    Continue to log these errors when encountered on a QWKhub (where they are
    less expected since a hub should normally have a deeper history of messages/polls than nodes will).



    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Thu Aug 29 17:43:02 2019
    src/sbbs3 qwk.cpp 1.89 1.90
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv12479

    Modified Files:
    qwk.cpp
    Log Message:
    Add more QWK vote-failure log messages so it should be possible to track down through debug-level log messages exactly why a QWK vote message failed to import.



    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sat Aug 31 19:38:33 2019
    src/sbbs3 qwk.cpp 1.90 1.91
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv4100

    Modified Files:
    qwk.cpp
    Log Message:
    Include message-ID in duplicate / failed vote-message log messages.



    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sat Apr 11 20:42:41 2020
    src/sbbs3 qwk.cpp 1.91 1.92
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv27529

    Modified Files:
    qwk.cpp
    Log Message:
    Vote-message-import failures from QWKnet hubs are now not treated as an
    error (e.g. trigger a bad QWK packet copy to be created). The debug-level
    log messages is still generated however.


    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Tue Apr 14 23:33:25 2020
    src/sbbs3 qwk.cpp 1.92 1.93
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv5168

    Modified Files:
    qwk.cpp
    Log Message:
    Fix bug in qwk_handle_remaining_votes(): If a QWK packet was not fully imported (e.g. because the console/terminal server was terminated locally), this routine would attempt to handle any remaining (unhandled) vote mesages and throw-up checking "conference number" access=0 invalid=invalid errors
    because it was trying to process all the (unhandled) sections in the VOTING.DAT file rather than just the sections beginning with the applicable section prefixes ("poll:", "vote:" or "close:"). Every other section is actually just a hex offset into the MESSAGES.DAT file and does not contain the "Conference"
    key that qwk_vote() was expecting to find.


    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Tue Apr 14 23:54:38 2020
    src/sbbs3 qwk.cpp 1.93 1.94
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv8719

    Modified Files:
    qwk.cpp
    Log Message:
    Include the VOTING.DAT section name in errors reported from qwk_vote() for better traceability.


    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Fri May 8 06:43:46 2020
    src/sbbs3 qwk.cpp 1.94 1.95
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv28765

    Modified Files:
    qwk.cpp
    Log Message:
    Mousify the QWK settings menu.


    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sat May 9 05:22:05 2020
    src/sbbs3 qwk.cpp 1.95 1.96
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv1577

    Modified Files:
    qwk.cpp
    Log Message:
    Clear mouse hotspots when existing the QWK config menu.


    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Mon Feb 15 04:17:15 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/b9540c9afbfbbcf17c47e6b9
    Modified Files:
    src/sbbs3/qwk.cpp
    Log Message:
    Don't use uninitialized variable in errormsg()

    Caught by Coverity.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sun Feb 21 20:29:11 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/937195956a590a4bafbf57a4
    Modified Files:
    src/sbbs3/qwk.cpp
    Log Message:
    Fix Coverity-reported use of uninitialized variable

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sun Apr 4 13:38:22 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/3b89e2e45023559b3ebc6240
    Modified Files:
    src/sbbs3/qwk.cpp
    Log Message:
    Fix incorrect buf size argument caught by Coverity-scan

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sun Apr 4 15:13:58 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/9ae5d681db51b86621d54deb
    Modified Files:
    src/sbbs3/qwk.cpp
    Log Message:
    The QWK reset sub ptr command would never work

    Caught by Coverity-scan CID 33178

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Tue Apr 20 22:04:33 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/95701fb79678e702bd647b90
    Modified Files:
    src/sbbs3/qwk.cpp
    Log Message:
    Don't log an error when a QWKnet node uploads votes for old messages

    Log an info-level message instead.
    Raise the log level severity of duplicate votes from Debug to Info too.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sat Jan 22 01:27:43 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/cac09153bb2b26fe24879a86
    Modified Files:
    src/sbbs3/qwk.cpp
    Log Message:
    Remove some commented-out code

    Posting restrictions are handled one QWK-message at a time (and have been for a long time). No actual change here.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net