• src/syncterm/ripper.c

    From Deuce@VERT to Git commit to sbbs/master on Fri Sep 4 17:10:24 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/510c424ae04cffe8bff9582d
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    stat.st_atim.tv_sec -> stat.st_atime

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Stephen Hurd@VERT to Git commit to sbbs/master on Tue Nov 10 17:55:53 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/feda0dba2b685f33191472d5
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Use sockwrap.h for arpa/inet.h and strwrap.h for stdndup()

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Stephen Hurd@VERT to Git commit to sbbs/master on Sat Nov 14 05:48:57 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/ee0df4bd61c6188df34cdc92
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Stop using ASCII caret for power of two.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Stephen Hurd@VERT to Git commit to sbbs/master on Mon Nov 16 04:47:05 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/480206149919a240a539cf40
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Fix most of the RIP issues found by coverity.

    Most are simple memory leaks, but some would cause crashes, and
    others would cause unexpected behaviour.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Stephen Hurd@VERT to Git commit to sbbs/master on Tue Nov 17 05:02:01 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/0f4eab23df7aab55c31b473b
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Remove duplicate fclose()

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Sat Mar 13 22:44:47 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/61022e183d56d3e58411a441
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Don't make parse_rip() do anything when RIP is disabled.

    Should fix file transfer issues.
    (SF bug #38)

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Sun Mar 14 22:57:48 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/21763a1df8ad975a60fe1147
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Add comments for all the things.

    Just copied out of the documentation.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Fri Apr 30 12:01:41 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/730c324235093b61f658e947
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Start of minimal RIPv2 support.

    Just the easy stuff (scaling, extended colours, border toggle, filled rectangle)

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Fri Apr 30 12:57:01 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/2c23c1a3218b32b9d05aba9a
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Remove debug, optimize

    Generate conversion tables rather than do float math twice for each
    virtual pixel.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Fri Apr 30 20:15:45 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/b9d43a4c3c635070dba52dc2
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Implement disabled text for RIP.

    We still need to pass ANSI through to the parser though because
    Synchronet goes apeshit if it doesn't get a response to a location
    request... it tries twice and eats any data it receives that isn't
    a valid position report, which obviously breaks menus.

    It's also very weird that on Booch's BBS at least it's sent during
    the main menu display rather than just on answering. Not sure why
    this is, but it means we can't implement the RIP requirement of
    "ignoring all non-RIPscrip bytes" with a zero window without digging
    deep into Synchronet guts.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Sat May 1 07:36:50 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/f5a3570f92d9b8844cd56e4b
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Fix merge issue.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Sat May 1 12:31:51 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/1a5fe6e2f0be45c3d8b4f5d2
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Some optimizations and clearing realloc()ed data.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Sun May 2 07:48:56 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/1075cd28c2e431aca992a1f6
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Add save/resotore mouse fields commands.

    Used extensively on Black Flag BBS.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Tue May 4 18:02:29 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/59053de5e06c260d968f7b5f
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Make some changes

    Mostly tightening things up and fixed some text things.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Wed May 5 20:56:53 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/faca73d3d0f6ae524be38e40
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Fix palette calculations, and add support for RIPv2 'b' command.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Thu May 6 19:06:55 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/19f0c215a6cc9402df40e158
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    More improvements...

    Consistently use map_rip_color()
    Optimize flood fill to not clobber the stack
    Fix small full ellipses to match RIPTerm 1.54

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Mon May 10 09:27:58 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/461d36a14af5b78d0632e3e5
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Draw the ellipse pixel when the angle is equal to start/end as well

    Being stritly less/greater causes a one pixel gap at the start/end
    of the ellipse, meaning flood fills can escape.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Mon May 10 09:56:33 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/37d8d708cb66298fb6848f6d
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Add extended comment on do_fill() and why it's terrible.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Tue May 11 09:07:54 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/498187eb3ef005678e9fa92f
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Fix angle calculations on Win32

    Do multiple before divide, and use an lround() to get the same results
    on Win32 with mingw32 as Clang on FreeBSD.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Sat May 15 01:02:25 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/88480afbb740365557ff502a
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Don't guard #pragma

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Wed May 19 23:34:16 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/2cc6b5d95b825488dd791c64
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Use fexistcase() for RIP assets

    It seems that at least LORD has upper-case in the ZIPs and lower-case
    in the queries.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Thu May 20 01:33:48 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/ab0256208977d1d2633be7f1
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    ifdef out an unused static function for now.

    It will be used in the future, so the code shouldn't be deleted,
    but not using it causes a warning.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Fri May 21 16:23:13 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/040172431ecfac608bf832a7
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Fix auto-transfers

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Fri May 21 16:23:13 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/05b3074f28d0352c216db376
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Send CRLF instead of the specified CR on a file status.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Tue Dec 20 21:18:30 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/0898c565823c2ef6dbd59741
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Separate RIP enabled from suspended.

    Previously, a file transfer would unconditionally enable RIP.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Sat Dec 24 11:42:51 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/bc6daf3f47edd4a37873fb7f
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Only check the filename for a dot, not the whole cachepath

    Fixes icon displays in RIPs that don't use the .ICN extension.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Sat Dec 24 13:46:02 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/8fd40b34e995ee25bfe410b9
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Some ellipse improvements to fix Violet's chat bubble when she's busy.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Sat Dec 24 22:10:13 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/c3b827088b502bbeef11fe6c
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Fix RIP_FILE_QUERY

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Wed Mar 29 16:29:18 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/41cd8c3af2366120df56154c
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Fix GCC 12.2 warning

    warning: argument 1 value ‘18446744073709551608’ exceeds maximum
    object size 9223372036854775807 [-Walloc-size-larger-than=]

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Wed Apr 26 12:14:15 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/ac4a967c92244c8c12ac6398
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Fix Win32 console (and likely curses) crash on connect

    RIP initialization was trying to obtain a lock that only exists when
    using a bitmap console. Don't allow RIP to be enabled, and don't
    perform the operations that require the lock when the CONIO_OPT_SET_PIXEL ciolib option is not set.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Wed Aug 2 22:57:40 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/236064ee462ca2be3b81cd77
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Properly read extended keys in non-graphics builds.

    Fixes SF issue 118

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Thu Feb 15 15:04:14 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/ec4a8c96c24994cb157ac491
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Move fiddling with rip.x_max and rip.y_max out of the vstat mutex.

    Apparently, fiddling with them in there "strongly implies" to Coverity
    that vstatlock needs to be held to access them, and it's good form
    to have the lock held for the least span possible.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Fri Mar 22 02:16:53 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/4ed27ca97ae7f21f56d038b6
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Use safer string things...

    We really need strlcpy()/strlcat() wrappers in xpdev.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net